ec2_win_password - migrate to boto3 #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
force-pushed
the
boto3/ec2_win_password
branch
from
1eb4f53 to
5c6a092
Compare
ansibullbot
added
community_review
feature
tremble
force-pushed
the
boto3/ec2_win_password
branch
from
5c6a092 to
0353fee
Compare
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
tremble
force-pushed
the
boto3/ec2_win_password
branch
from
0353fee to
e025e7a
Compare
tremble
force-pushed
the
boto3/ec2_win_password
branch
from
e025e7a to
c4dcc7f
Compare
ansibullbot
added
needs_maintainer
tests
tremble
force-pushed
the
boto3/ec2_win_password
branch
from
c4dcc7f to
58e30ad
Compare
alinabuzachis
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Migrate ec2_win_password to boto3
ISSUE TYPE
COMPONENT NAME
ec2_win_password
ADDITIONAL INFORMATION
While there are no tests for this module, there's only a single boto call to update
boto2 documentation of call: http://boto.cloudhackers.com/en/latest/ref/ec2.html#boto.ec2.connection.EC2Connection.get_password_data
boto3 documentation of call: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2.html#EC2.Client.get_password_data